Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'downloads' and 'virustotals' tables #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve 'downloads' and 'virustotals' tables #153

wants to merge 2 commits into from

Conversation

mcantoni
Copy link
Contributor

ISSUE TYPE
  • Feature
DIONAEA VERSION
master
OS / ENVIRONMENT
Ubuntu 16.04.4 LTS
SUMMARY

Improve logging support. Add some info to 'downloads' and 'virustotals' tables:

download_timestamp

virustotal_sha1_hash
virustotal_sha256_hash
virustotal_positives
virustotal_total

sqlite> PRAGMA table_info(downloads);
0|download|INTEGER|0||1
1|connection|INTEGER|0||0
2|download_url|TEXT|0||0
3|download_md5_hash|TEXT|0||0
4|download_timestamp|INTEGER|0||0

sqlite> PRAGMA table_info(virustotals);
0|virustotal|INTEGER|0||1
1|virustotal_md5_hash|TEXT|1||0
2|virustotal_sha1_hash|TEXT|1||0
3|virustotal_sha256_hash|TEXT|1||0
4|virustotal_positives|INTEGER|1||0
5|virustotal_total|INTEGER|1||0
6|virustotal_timestamp|INTEGER|1||0
7|virustotal_permalink|TEXT|1||0

@phibos
Copy link
Member

phibos commented Mar 14, 2018

Thanks for your work but I think there should be an ALTER command to migrate existing tables to the new format. What do you think?

@phibos phibos self-assigned this Mar 14, 2018
@phibos phibos added this to the 0.8.0 milestone Mar 14, 2018
@mcantoni
Copy link
Contributor Author

mcantoni commented Apr 6, 2018

You are right, a new solution: ab43f15

@phibos phibos modified the milestones: 0.8.0, 0.9.0 Jun 15, 2018
@phibos phibos removed this from the 0.9.0 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phibos phibos

Labels
Type: Enhancement Type: Tech discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcantoni @phibos